Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP rate limiting #502

Open
1 of 2 tasks
ewdurbin opened this issue Oct 1, 2024 · 2 comments · May be fixed by #509
Open
1 of 2 tasks

HTTP rate limiting #502

ewdurbin opened this issue Oct 1, 2024 · 2 comments · May be fixed by #509
Assignees
@JacobCoffee
Labels
loadbalancer Relates to loadbalancer services

Comments

@ewdurbin
Copy link
Member

ewdurbin commented Oct 1, 2024 •
edited by JacobCoffee
Loading

We currently have a couple services that ostensibly have HTTP rate limiting configured, but it is not clear that it is functioning as expected. Namely bugs/roundup which is a pretty consistent noisy service due to crawlers/traffic.

Let's assess the current state of rate limiting for services managed by our salt infrastructure and being served by our haproxy load balancers (it should be all of them?) to determine the functionality of rate limiting and if there's some way we could consolidate that rate limiting into the haproxy layer rather than having it be service by service.

Tasks
Beta Give feedback
@JacobCoffee JacobCoffee added the loadbalancer Relates to loadbalancer services label Oct 3, 2024
@JacobCoffee
Copy link
Member

I think this is the list of items not behind (most/all are expected I think?)

  • backups
  • consul
  • cdn-logs
  • mail
  • Mailman3
  • Pythontest

@JacobCoffee
Copy link
Member

could the lb health checks be not helping here?

coffee@bugs:~$ tail -1000 /var/log/nginx/roundup-cpython.access.log | awk '{print $1}' | sort | uniq -c | sort -n | tail
...
15 ...
29 ...
31 ...
53 ...
**82 10.132.111.89**
**83 10.132.109.52**

@JacobCoffee JacobCoffee linked a pull request Oct 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobCoffee JacobCoffee

Labels
loadbalancer Relates to loadbalancer services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: apply sliding window rate limiting python/psf-salt
2 participants
@ewdurbin @JacobCoffee