Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for keyring as a subprocess subprocess (rather than keyring as an import) #9472

Open
jfly opened this issue Jun 5, 2024 · 2 comments
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged

Comments

@jfly
Copy link
Contributor

jfly commented Jun 5, 2024

Issue Kind

Brand new capability

Description

Poetry has support for pulling authentication information out of the system keyring. This (largely) works the same as pip's keyring support, and the documentation even references pip's behavior:

Poetry will fallback to Pip style use of keyring so that backends like Microsoft’s artifacts-keyring get a chance to retrieve valid credentials

However, poetry does not have support for invoking keyring as a subprocess (see pip's documentation for this here).

Impact

The author of pip's keyring support actually intended for people to use it as a subprocess, rather than an import ("As the author of the --keyring-provider flag I recommend you use the subprocess provider").

My company would like to use it to avoid a chicken/egg problem (bootstrapping a single systemwide keyring binary with the appropriate keyring backend is easier than doing it for every installation of poetry), and to keep our configuration as in sync with pip as possible.

Workarounds

The alternative is for people to carefully configure their poetry venv to be configured the same as their global keyring installation.

@jfly jfly added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Jun 5, 2024
@dimbleby
Copy link
Contributor

dimbleby commented Jun 5, 2024

poetry is not pip and is not trying to imitate pip, I doubt it will ever add support for pip-specific environment variables

you could try rewording this in terms of a native poetry feature. But given that your workaround already is to configure poetry to do what you want it to do perhaps nothing is missing.

@jfly jfly changed the title Feature parity with pip's keyring support Add support for keyring as a subprocess subprocess (rather than keyring as an import) Jun 6, 2024
@jfly
Copy link
Contributor Author

jfly commented Jun 6, 2024

@dimbleby, got it. I've reworded this to just be a feature request asking for support for "keyring as a subprocess" in addition to poetry's "keyring as an import" functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants