More robust evaluation of assignments #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracks the `target_name` that we are recursively evaluating, and short-circuits evaluation if we attempt to evaluate that name again. Also allows the assignment evaluation to try multiple assignments until either a real value is found, or all assignments are exhausted. Also prevents combining lhs and rhs of binary addition if either side is the `"??"` sentinel value. Fixes python-packaging#56
|
Final metadata evaluated against onnx repo: (.venv) jreese@mordin ~/workspace/dowsing onnx » python -m dowsing.pep517 ~/scratch/onnxruntime | jq .get_metadata
{
"metadata_version": "2.1",
"name": "onnxruntime-openvino",
"version": "??",
"summary": "ONNX Runtime is a runtime accelerator for Machine Learning models",
"description": "??",
"keywords": "onnx machine learning",
"home_page": "https://onnxruntime.ai",
"author": "Microsoft Corporation",
"author_email": "[email protected]",
"license": "MIT License",
"classifiers": [
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Developers",
"License :: OSI Approved :: MIT License",
"Operating System :: POSIX :: Linux",
"Topic :: Scientific/Engineering",
"Topic :: Scientific/Engineering :: Mathematics",
"Topic :: Scientific/Engineering :: Artificial Intelligence",
"Topic :: Software Development",
"Topic :: Software Development :: Libraries",
"Topic :: Software Development :: Libraries :: Python Modules",
"Programming Language :: Python",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9"
],
"requires_dist": "??",
"package_data": "??",
"packages": [
"onnxruntime",
"onnxruntime.backend",
"onnxruntime.capi",
"onnxruntime.capi.training",
"onnxruntime.datasets",
"onnxruntime.tools",
"onnxruntime.tools.ort_format_model",
"onnxruntime.tools.ort_format_model.ort_flatbuffers_py",
"onnxruntime.tools.ort_format_model.ort_flatbuffers_py.fbs",
"onnxruntime.quantization",
"onnxruntime.quantization.operators",
"onnxruntime.quantization.CalTableFlatBuffers",
"onnxruntime.transformers",
"onnxruntime.transformers.longformer"
],
"packages_dict": {
"onnxruntime": "onnxruntime",
"onnxruntime.backend": "onnxruntime/backend",
"onnxruntime.capi": "onnxruntime/capi",
"onnxruntime.capi.training": "onnxruntime/capi/training",
"onnxruntime.datasets": "onnxruntime/datasets",
"onnxruntime.tools": "onnxruntime/tools",
"onnxruntime.tools.ort_format_model": "onnxruntime/tools/ort_format_model",
"onnxruntime.tools.ort_format_model.ort_flatbuffers_py": "onnxruntime/tools/ort_format_model/ort_flatbuffers_py",
"onnxruntime.tools.ort_format_model.ort_flatbuffers_py.fbs": "onnxruntime/tools/ort_format_model/ort_flatbuffers_py/fbs",
"onnxruntime.quantization": "onnxruntime/quantization",
"onnxruntime.quantization.operators": "onnxruntime/quantization/operators",
"onnxruntime.quantization.CalTableFlatBuffers": "onnxruntime/quantization/CalTableFlatBuffers",
"onnxruntime.transformers": "onnxruntime/transformers",
"onnxruntime.transformers.longformer": "onnxruntime/transformers/longformer"
},
"entry_points": {
"console_scripts": [
"onnxruntime_test = onnxruntime.tools.onnxruntime_test:main"
]
}
} |
|
A test would be nice, even if it's invalid python (unbound local x=x). |
thatch
reviewed
Feb 9, 2022
amyreese
changed the title
|
Running this on onnxruntime now produces |
|
Seems to produce issues when redefining builtins; see https://gist.github.com/thatch/ebc427075958a2338b7b7d712f77b01e for a simplified version of one that is copypasted over many popular projects' setup.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves assignment evaluation in a number of ways:
"??"+=This enables support for evaluating self-referential assignments like:
or
Adds a basic test covering both self-referential assignment types.
Fixes #56