Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure null bytes round trip #3

Merged
merged 6 commits into from
Jul 6, 2023
Merged

fix: ensure null bytes round trip #3

merged 6 commits into from
Jul 6, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 6, 2023

If the encrypted string contained null bytes it would be truncated when it came back from the native code

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4a09a40) 96.55% compared to head (3a52be9) 96.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files           2        2           
  Lines          29       29           
  Branches        2        2           
=======================================
  Hits           28       28           
  Misses          1        1           
Impacted Files Coverage Δ
src/kasa_crypt/__init__.py 91.66% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review July 6, 2023 02:04
@bdraco bdraco merged commit 9512615 into main Jul 6, 2023
27 checks passed
@bdraco bdraco deleted the null_bytes branch July 6, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant