-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'.' removed from platform names #311
Comments
For macOS, The simplest and most compatible way I've found to distribute wheels for macOS is to install the standard Python packages from python.org and build the wheels using them. These install into |
I am building using the python.org binaries. What you say about On the one hand I find Cython.
Which explicitly mentions both intel and x86_64, as well as several macosx version (10.6, 10.9, and 10.10). On the other I find numpy with a far shorter:
Is there some history to explain this difference? Was this verbosity necessary in the past? I guess I should follow what is done for numpy? |
Yes, there are (very) historic reasons for expansive naming, but even Cython is stopping doing that. See matthew-brett/multibuild@02777c9#diff-c6138a165d27a77acc4f03c58856b4de |
Thanks for the clarification. I guess the expansive As a note I found the output of |
Somewhat unrelated to the issue, but since pip 19.2, |
In trying to figure out how to build wheels of OSX I (naively?) tried:
I find that the resulting .whl is named
cythonxx_demo-0.0.0-cp37-cp37m-macosx_10_6_intel_macosx_10_6_x86_64.whl
and the WHEEL file containsBased on PEP 491 and some reading I was expecting this to be
cythonxx_demo-0.0.0-cp37-cp37m-macosx_10_6_intel.macosx_10_6_x86_64.whl
(with a.
) and:Though my expectations may very well be wrong. I don't claim to have a good understanding of how OSX platform names are used.
Looking into the code I see an apparent conflict.
plat_tag
is expected to contains dots (.
).wheel/wheel/bdist_wheel.py
Lines 275 to 279 in b227ddd
But
get_tags()
has already replaced these.wheel/wheel/bdist_wheel.py
Line 156 in b227ddd
The text was updated successfully, but these errors were encountered: