-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sw_extras soundspeed method Delgrosso correction #92
Comments
Thanks for the report. Do you want to send a PR to fix that? |
This section in Issue track -> sw_extras.py line 669
`
This is how the Matlab function is:
|
The matlab one may be wrong. A PR to fix that according to the Unesco ref would be welcomed! I'm not an expert on this field so I'd appreciate if someone could look up the latest references on the topic to make sure the equation implemented yields the correct values. |
XX = np.sin(45 * np.pi / 180) need to be squared
And verify whole formula:
Fofonoff 1983, page 28 (https://repository.oceanbestpractices.org/bitstream/handle/11329/109/059832eb.pdf?sequence=1&isAllowed=y)
GR = 9.780318 * (1.0 + (5.2788e-3 + 2.36e-5 * XX) * XX) + 1.092e-6 * D
P = D / GR
The text was updated successfully, but these errors were encountered: