You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When making use of custom quality an episode that is already downloaded with a quality in the Allowed list will be upgraded to another quality in the Allowed list instead of only the Preferred list.
To Reproduce
Steps to reproduce the behavior:
Create a custom quality set such as the screenshot in the screenshots section which allows any 720p & 1080p, but prefers 4k.
Have an episode with quality from the Allowed list download (daily search in my case).
See it get upgraded to an episode of higher quality in the Allowed list through a daily search or backlog search.
The log is below, but this is what is seen and causes an upgrade from 1080p HDTV to 1080p WEB-DL (I'm assuming WEB-DL is considered higher quality compared to HDTV):
2024-05-09 11:41:39 INFO SEARCHQUEUE-BACKLOG-56 :: [Indexer] :: [34a67cf] Episodes [11] of season 11 are needed with this quality for Showname
2024-05-09 11:41:39 DEBUG SEARCHQUEUE-BACKLOG-56 :: [Indexer] :: [34a67cf] 56: 'Showname' S11E11 status is: 'Downloaded'. Accepting result with quality '1080p WEB-DL'. Reason: New quality is higher quality (and allowed). Accepting new quality
2024-05-09 11:41:39 DEBUG SEARCHQUEUE-BACKLOG-56 :: [Indexer] :: [34a67cf] 56: Allowed, Preferred = [ 720p HDTV, 1080p HDTV, 720p WEB-DL, 1080p WEB-DL, 720p BluRay, 1080p BluRay ] [ 4K UHD TV, 4K UHD WEB-DL, 4K UHD BluRay ] Found = [ 1080p WEB-DL ]
2024-05-09 11:41:39 INFO SEARCHQUEUE-BACKLOG-56 :: [Indexer] :: [34a67cf] Quality of Showname.S11E11.1080p.WEB.h264-ELEANOR is 1080p WEB-DL
In short, if qualities are set in both the Allowed and Preferred categories, Medusa will download up to one release from the allowed category and one release from the preferred category even if a higher quality preferred release is released at a later date.
Screenshots
Medusa (please complete the following information):
If you have qualities in BOTH lists, it will accept any quality in the Allowed list, and continue looking for a better quality in the Preferred list, until it finds one. Once Medusa finds a match in the preferred list, it stops looking.
In general I don't have a problem with this except that it has the capability of using up block data to download on episode of similar quality (1080p HDTV vs 1080p WEB-DL) and in my specific use case it is also overwriting an episode with a preferred compression (based on preferred words in the screenshot above) with an episode with an undesired compression as I prefer 265 over 264.
I'm not entirely sure if it will be considered a bug, but does seem to be one when comparing the behaviour against the documentation, but if it's considered not a bug is there a possibility of adding some logic in to also consider preferred words before downloading the episode. In this case the result is penalized due to the undesired word, but still used due to it being a higher quality, but I would suggest not downloading it due to the existing result having a desired word (and still cached).
The text was updated successfully, but these errors were encountered:
If it worked the way you a asking for then you could be stuck with a 720 HDTV if no 4K ever shows up..
I prefer to get the best quality possible..
But I would like to see the quality revamped to a format like 720p-x264 AAC-2ch removing media like BluRay since it has nothing to do with the quality of the show... And HDTV is what ever...
Describe the bug
When making use of custom quality an episode that is already downloaded with a quality in the Allowed list will be upgraded to another quality in the Allowed list instead of only the Preferred list.
To Reproduce
Steps to reproduce the behavior:
The log is below, but this is what is seen and causes an upgrade from 1080p HDTV to 1080p WEB-DL (I'm assuming WEB-DL is considered higher quality compared to HDTV):
Expected behavior
As described in https://github.com/pymedusa/Medusa/wiki/Quality-Settings#custom-qualities only a single release from the Allowed list should be downloaded:
Screenshots
Medusa (please complete the following information):
Debug logs (at least 50 lines):
General > Advanced Settings > Enable debug
Additional context
At first I thought it may be due to https://github.com/pymedusa/Medusa/wiki/Qualities-Changes but the last paragraph states that it will only continue to look in the Preferred list:
In general I don't have a problem with this except that it has the capability of using up block data to download on episode of similar quality (1080p HDTV vs 1080p WEB-DL) and in my specific use case it is also overwriting an episode with a preferred compression (based on preferred words in the screenshot above) with an episode with an undesired compression as I prefer 265 over 264.
I'm not entirely sure if it will be considered a bug, but does seem to be one when comparing the behaviour against the documentation, but if it's considered not a bug is there a possibility of adding some logic in to also consider preferred words before downloading the episode. In this case the result is penalized due to the undesired word, but still used due to it being a higher quality, but I would suggest not downloading it due to the existing result having a desired word (and still cached).
The text was updated successfully, but these errors were encountered: