Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic casting of integers in convert_observed_data #7331

Open
ricardoV94 opened this issue May 22, 2024 · 0 comments
Open

Problematic casting of integers in convert_observed_data #7331

ricardoV94 opened this issue May 22, 2024 · 0 comments

Comments

@ricardoV94
Copy link
Member

Description

When we use pytensor.config.floatX=="float32", integer data is downcast to "int16" which has a pretty limited range of 32k. For count-based likelihoods this is way too narrow. I am not sure we should be doing anything with integers to begin with. Why are PyTensor casting rules (and customization flags) not sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant