Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and lint all the nox commands #1963

Closed
Carreau opened this issue Aug 20, 2024 · 1 comment
Closed

Test and lint all the nox commands #1963

Carreau opened this issue Aug 20, 2024 · 1 comment

Comments

@Carreau
Copy link
Collaborator

Carreau commented Aug 20, 2024

See #1962

It looks like some of the nox commands have been broken for a while.

This should be tested/linted in CI.

I also realized we don't run typechecker like mypy on the codebase – yes this is a theme, and docutils might trigger a number of false-positive but I think we should still add mypy.

@trallard
Copy link
Collaborator

+1 on using mypy - we are moving away from nox. I just had not gotten around to moving the translation bits to tox, but this should be done in #1959

So let's close this issue and open one for mypy checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants