Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing aria-current #1886

Open
gabalafou opened this issue Jun 18, 2024 · 3 comments
Open

Missing aria-current #1886

gabalafou opened this issue Jun 18, 2024 · 3 comments
Labels
tag: accessibility Issues related to accessibility issues or efforts

Comments

@gabalafou
Copy link
Collaborator

We should mark the current page in the nav using aria-current.

I couldn't find an issue that already tracks this.

@gabalafou
Copy link
Collaborator Author

Point of clarification: we currently use aria-current in the breadcrumb nav but I wonder if we should apply it to the sidebar (and top bar) nav too.

@drammock
Copy link
Collaborator

SGTM. Assuming that the top nav only gets aria-current when user is actually on a top-level page right? (not when on any page within that top-level section)

@trallard trallard added the tag: accessibility Issues related to accessibility issues or efforts label Jun 20, 2024
@gabalafou
Copy link
Collaborator Author

gabalafou commented Jul 3, 2024

SGTM. Assuming that the top nav only gets aria-current when user is actually on a top-level page right? (not when on any page within that top-level section)

Yes that's what I had in mind, plus doing some research into what's the best-practice way to indicate the path parts to assistive tech the same way that we apply an underline in the top nav to the area that the user is in and a notch to the section in the sidebar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: accessibility Issues related to accessibility issues or efforts
Projects
None yet
Development

No branches or pull requests

3 participants