Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI test for docs build of selected Scientific Python projects #1851

Open
melissawm opened this issue Jun 3, 2024 · 5 comments
Open

Add CI test for docs build of selected Scientific Python projects #1851

melissawm opened this issue Jun 3, 2024 · 5 comments
Labels
kind: enhancement New feature or request tag: CI Pull requests that update GitHub Actions code

Comments

@melissawm
Copy link
Contributor

To avoid breakage and unexpected problems when a release is made, we could add a CI job that builds the docs pages for a list of selected projects and verifies that the output is as expected. Ideally, it would run as a cron job (and not on every CI run).

@trallard trallard added kind: enhancement New feature or request tag: CI Pull requests that update GitHub Actions code labels Jun 4, 2024
@melissawm
Copy link
Contributor Author

The following projects seem like reasonable candidates:

@12rambau
Copy link
Collaborator

12rambau commented Jun 5, 2024

What would be the "expected output" ? It's very difficult to get CI to check for how things render on our own website already.

@trallard
Copy link
Collaborator

trallard commented Jun 5, 2024

I think there are two things that could be tested

  1. That the build process of third party docs is successful - this can be easily checked in CI and mostly helps us catch any unintentional breaking changes introduced by us or some of our dependencies.
  2. Visually inspecting the build - this is definitely hard from a CI only POV and unless we have visual regression tests (which would be a great amount of work on our end to write and maintain as we continue to work on the theme) there is no way to do but through a manual check. So IMHO this should be out of our scope.

So we should only focus on 1. for the time being

@melissawm
Copy link
Contributor Author

For completeness, it may be also helpful to have https://github.com/executablebooks/sphinx-book-theme

@drammock
Copy link
Collaborator

For completeness, it may be also helpful to have https://github.com/executablebooks/sphinx-book-theme

yep. We recently broke something for them (#1875 (comment)) so definitely makes sense to include

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement New feature or request tag: CI Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

4 participants