Split and refactor generate_header_nav_before_dropdown #1773
Comments
Carreau
added a commit
to Carreau/pydata-sphinx-theme
that referenced
this issue
Apr 23, 2024
On top of pydata#1771, should fix pydata#1773 (once fininished) This try to split the function into two parts: one that wrangle the data, one that generate html. The generating the data part should be cacheable, while the other can be made more flexible to be reusable in different part of the theme (typically generating or not dropdowns in the sidebar or navbar).
Carreau
added a commit
to Carreau/pydata-sphinx-theme
that referenced
this issue
May 2, 2024
On top of pydata#1771, should fix pydata#1773 (once fininished) This try to split the function into two parts: one that wrangle the data, one that generate html. The generating the data part should be cacheable, while the other can be made more flexible to be reusable in different part of the theme (typically generating or not dropdowns in the sidebar or navbar).
Carreau
added a commit
to Carreau/pydata-sphinx-theme
that referenced
this issue
May 7, 2024
On top of pydata#1771, should fix pydata#1773 (once fininished) This try to split the function into two parts: one that wrangle the data, one that generate html. The generating the data part should be cacheable, while the other can be made more flexible to be reusable in different part of the theme (typically generating or not dropdowns in the sidebar or navbar).
Carreau
added a commit
to Carreau/pydata-sphinx-theme
that referenced
this issue
May 14, 2024
On top of pydata#1771, should fix pydata#1773 (once fininished) This try to split the function into two parts: one that wrangle the data, one that generate html. The generating the data part should be cacheable, while the other can be made more flexible to be reusable in different part of the theme (typically generating or not dropdowns in the sidebar or navbar).
Carreau
added a commit
that referenced
this issue
May 22, 2024
Refactor navbar generating function. This should fix #1773 (once fininished) It tries to split the function into two parts: one that wrangle the data, one that generate html. The generating the data part should be cacheable, while the other can be made more flexible to be reusable in different part of the theme (typically generating or not dropdowns in the sidebar or navbar). --------- Co-authored-by: Daniel McCloy <[email protected]>
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this issue
Jun 5, 2024
Refactor navbar generating function. This should fix pydata#1773 (once fininished) It tries to split the function into two parts: one that wrangle the data, one that generate html. The generating the data part should be cacheable, while the other can be made more flexible to be reusable in different part of the theme (typically generating or not dropdowns in the sidebar or navbar). --------- Co-authored-by: Daniel McCloy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think we need to split this function to not return html but just the necessary bits to generate the html for the navs, and have separate functions to generate navs in different place instead of messing with html strings.
We should also make it clearer function are exposed to end users of the theme.
Originally posted by @Carreau in #1771 (comment)
The text was updated successfully, but these errors were encountered: