Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytes is currently rendered wrong #31

Open
samuelcolvin opened this issue Dec 1, 2023 · 3 comments · May be fixed by #106
Open

bytes is currently rendered wrong #31

samuelcolvin opened this issue Dec 1, 2023 · 3 comments · May be fixed by #106
Labels
bug Something isn't working
Milestone
v0.7.0

Comments

@samuelcolvin
Copy link
Member

Currently bytes becomes 'format': 'binary' in JSON Schema, which in turn means it get's rendered as a file input.

I'm not sure what the best solution is, maybe we just support the base64 types and solve it that way.
@samuelcolvin samuelcolvin added the bug Something isn't working label Dec 1, 2023
@WolfDWyc
Copy link
Contributor

WolfDWyc commented Dec 2, 2023

For some reason, I am not experiencing this. I just changed the Users model in the README demo to have the name as bytes and it renders the same.

@samuelcolvin
Copy link
Member Author

Does it submit ok?

@WolfDWyc
Copy link
Contributor

WolfDWyc commented Dec 2, 2023

Oh, I understand now.

@ischaojie ischaojie linked a pull request Dec 18, 2023 that will close this issue
Open
@sydney-runkle sydney-runkle added this to the v2.6.0 milestone Apr 19, 2024
@sydney-runkle sydney-runkle modified the milestones: v0.6.0, v0.7.0 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Fix bytes rendered wrong ischaojie/FastUI
3 participants
@samuelcolvin @sydney-runkle @WolfDWyc