Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Release action fails on soft-prop #401

Open
BradyPlanden opened this issue Jul 8, 2024 · 1 comment
Open

[Bug]: Release action fails on soft-prop #401

BradyPlanden opened this issue Jul 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

Python Version

3.11

Describe the bug

The release action is failing during the signing and uploading of the built wheels due to a soft-prop issue: https://github.com/pybop-team/PyBOP/actions/runs/9839631010

The generated error is for soft-prop@v1, however, v2 is defined in the action and approved on the repository. @agriyakhetarpal, do you mind taking a look at this one?

Steps to reproduce the behaviour

See v24.6 release action: https://github.com/pybop-team/PyBOP/actions/runs/9839631010

Relevant log output

No response

@BradyPlanden BradyPlanden added the bug Something isn't working label Jul 8, 2024
@agriyakhetarpal
Copy link
Member

Strange, I think this was either a GitHub error or that one of the actions is a composite action that uses v1 internally. Should we allow the use of external actions? If and as long as we make approvals required workflow runs for any outside collaborators, that should limit the use of actions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants