Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer BrowserOptions overlaps with Lighthouse Config #231

Open
BioPhoton opened this issue Apr 3, 2023 · 0 comments
Open

Puppeteer BrowserOptions overlaps with Lighthouse Config #231

BioPhoton opened this issue Apr 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@BioPhoton
Copy link
Contributor

BioPhoton commented Apr 3, 2023

To handle different device sizes we have different places to configure them:

  • Lighthouse Config
  • Puppeteer Browser

Lighthouse Config

const lighthouseConfig: Config = {
  extends: 'lighthouse:default',
  settings: {
    formFactor: 'desktop',      
    screenEmulation: {
      mobile: false,
      width: 1350,
      height: 940,
      deviceScaleFactor: 1,
      disabled: false
    }
  }
}

This setting applies to the browsers window not the viewport.

Puppeteer BrowserOptions

// 
const browserOptions: BrowserOptions = {
  defaultViewport: { 
  isMobile: false, 
  isLandscape: false, 
   width: 1350,
   height: 940,
  }
}

This setting applies to the Browsers viewport, not window.

BrowserOptions-vs-LhConfig


This issue is slightly connected with #142

@BioPhoton BioPhoton changed the title Browser LaunchOptions overlaps with Lighthouse Config Puppeteer BrowserOptions overlaps with Lighthouse Config Apr 3, 2023
@BioPhoton BioPhoton added the bug Something isn't working label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant