Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurements are not useable by the next steps #121

Open
sonallux opened this issue Oct 2, 2023 · 1 comment · May be fixed by #122
Open

Measurements are not useable by the next steps #121

sonallux opened this issue Oct 2, 2023 · 1 comment · May be fixed by #122

Comments

@sonallux
Copy link

sonallux commented Oct 2, 2023

Thanks for creating user-flow and this corresponding action.

I would like to output the measurements in html and json format and then upload them as an artifact in GitHub actions to be able to make a deeper analysis. Unfortunately, this is currently not possible with this actions because of this two issues:

The format input is ignored

The format input of this action is completely useless because the format is hardcoded to markdown here:

// override format
ghActionInputs.format = ['md'];

Instead, I would just append the markdown format to the provided list of formats, so a user can still select which other formats should be created.

Output folder is deleted

Secondly, the output folder with the measurements is always deleted after processing the results:

// cleanup tmp folder
if (existsSync(resultsOutPath)) {
rmdirSync(resultsOutPath, {recursive: true});
}

I would remove this code so the output and all measurement files are accessible by further workflow steps.


Let me know what you think about this and if I can provide a PR with those two fixes.

sonallux added a commit to sonallux/user-flow-gh-action that referenced this issue Oct 4, 2023
@sonallux sonallux linked a pull request Oct 4, 2023 that will close this issue
@sonallux
Copy link
Author

sonallux commented Oct 8, 2023

@BioPhoton I have created PR #122 to fix these issues. I am looking forward to your feedback 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant