Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use runExecutor from @nx/devkit instead of importing the executor implementation #6

Open
getlarge opened this issue Sep 14, 2024 · 4 comments
Open

refactor: use runExecutor from @nx/devkit instead of importing the executor implementation #6

getlarge opened this issue Sep 14, 2024 · 4 comments
Labels
🧹 maintenance Maintenance and cleanup

Comments

@getlarge
Copy link
Collaborator

There might be a small performance penalty, but it will ensure that options for a given configuration are loaded (it might be very useful in the future of this tool!) and validated.
@getlarge getlarge changed the title refactor: use runExecutor instead of importing the executor implementation refactor: use runExecutor from @nx/devkit instead of importing the executor implementation Sep 14, 2024
@BioPhoton
Copy link
Contributor

@getlarge Thanks for the input. I'm fine with the small perf panalty.
Could you be so kind and point out where we should use it? Like file and line pls 🙏

@getlarge
Copy link
Collaborator Author

I can do it. Just wanted to be sure you are with that.

@BioPhoton
Copy link
Contributor

It seems in this repo there is not a lot of discussion need :)

@BioPhoton BioPhoton added the 🧹 maintenance Maintenance and cleanup label Sep 16, 2024
@BioPhoton
Copy link
Contributor

Started implemented it and love it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧹 maintenance Maintenance and cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BioPhoton @getlarge