Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statVerbosity in spago.yaml not respected #1249

Closed
drewolson opened this issue Jul 7, 2024 · 3 comments
Closed

statVerbosity in spago.yaml not respected #1249

drewolson opened this issue Jul 7, 2024 · 3 comments

Comments

@drewolson
Copy link
Contributor

Here's a simple reproduction:

$ spago --version
0.93.36
$ purs --version
0.15.15
$ mkdir foo                                                                                                                                                                                                                  
$ cd foo                                                                                                                                                                                                                     
$ spago init                                                                                                                                                                                                             
Initializing a new project...                                                                                                                                                                                                           
Refreshing the Registry Index...                                                                                                                                                                                                        
Found PureScript 0.15.15, will use package set 53.2.0                                                                                                                                                                                   
Set up a new Spago project.                                                                                                                                                                                                             
Try running `spago run`                                                                                                                                                                                                                 
$ vim spago.yaml                                                                                                                                                                                                         
$ cat spago.yaml                                                                                                                                                                                                         
package:                                                                                                                                                                                                                                
  name: foo                                                                                                                                                                                                                             
  dependencies:                                                                                                                                                                                                                         
    - console                                                                                                                                                                                                                           
    - effect                                                                                                                                                                                                                            
    - prelude                                                                                                                                                                                                                           
  test:                                                                                                                                                                                                                                 
    main: Test.Main                                                                                                                                                                                                                     
    dependencies: []                                                                                                                                                                                                                    
workspace:                                                                                                                                                                                                                              
  packageSet:                               
    registry: 53.2.0                                                                                                
  extraPackages: {}                                     
buildOpts:                                                                                                          
  statVerbosity: "no-stats"
$ spago build
Reading Spago workspace configuration...

✅ Selecting package to build: foo

Downloading dependencies...
Building...
           Src   Lib   All
Warnings     0     0     0
Errors       0     0     0

✅ Build succeeded.
@f-f
Copy link
Member

f-f commented Jul 8, 2024

This is a bug that my fix in #1241 didn't cover - the right patch should be somewhere around there, if anyone would like to have a look

@fsoikin
Copy link

fsoikin commented Jul 21, 2024

I spent an embarrassing amount of time debugging this, and finally realized that buildOpts should go under workspace, not at top level.

When it's under workspace, this seems to work just as expected.

Or did I misunderstand the assignment?

@f-f
Copy link
Member

f-f commented Jul 21, 2024

Oh 🤦 I entirely missed this as well - thanks for catching it @fsoikin!

This is another issue stemming from #1165

@f-f f-f closed this as completed Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants