Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work behind proxy #1233

Open
alaendle opened this issue Jun 17, 2024 · 2 comments
Open

Doesn't work behind proxy #1233

alaendle opened this issue Jun 17, 2024 · 2 comments

Comments

@alaendle
Copy link

Mainly because of using affjax for the requests (purescript-contrib/purescript-affjax#131):

let packageUrl = "https://packages.registry.purescript.org/" <> PackageName.print name <> "/" <> versionString <> ".tar.gz"
logInfo $ "Fetching package " <> packageVersion
response <- liftAff $ withBackoff' do
res <- Http.request
( Http.defaultRequest
{ method = Left Method.GET

Resulting in pretty generic error message like:
grafik

@f-f
Copy link
Member

f-f commented Jun 17, 2024

How would proxy support work? Like, should Spago be picking up the usual environment variables?
In that case I guess we should use http-proxy to pick up these vars? (and switch from affjax to fetch I guess?

@alaendle
Copy link
Author

@f-f Sounds good to me. I really had hoped that some library supports this out-of-the box - without any ceremonies. The interesting observation is that spago already comes so far since the package set is fetched via git - which respects the proxy environment variables 😄 Unfortunately, I will not be able to contribute via PR - as I only noticed this in passing, but I still wanted to record this issue as a reference - since it is not immediately obvious by just looking at the error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants