Deprecated GitHub API usage when uploading releases

[hdgarrood]

I received this email yesterday from GitHub: it sounds like the script for uploading release binaries is using a deprecated API. Hopefully updating the github-release version should be sufficient to fix this? I’m not sure.

Hi @hdgarrood,

On February 8th, 2020 at 00:21 (UTC) your personal access token (AppVeyor psc-package release uploads) using Go-http-client/1.1 was used as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/repositories/81163698/releases

Please use the Authorization HTTP header instead, as using the access_token query parameter is deprecated and will be removed July 1st, 2020.

[justinwoo]

Looks like the github-release tool and the fork won't work

psc-package/appveyor.yml

Line 29 in 01263f5

(New-Object Net.WebClient).DownloadFile('https://github.com/aktau/github-release/releases/download/v0.7.2/windows-amd64-github-release.zip', 'c:\tools\github-release.zip')

We use the newest version already https://github.com/aktau/github-release/releases

So probably we need to replace this altogether

[hdgarrood]

Ah right yeah, that’s a shame. FWIW Travis CI offers windows builds now and that’s what we use for the compiler, they seem to work well enough.