Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port MagicDo optimizer #14

Open
felixSchl opened this issue Sep 4, 2018 · 3 comments
Open

Port MagicDo optimizer #14

felixSchl opened this issue Sep 4, 2018 · 3 comments

Comments

@felixSchl
Copy link
Collaborator

@felixSchl felixSchl added enhancement New feature or request good first issue Good for newcomers performance optimization labels Sep 4, 2018
@joneshf
Copy link

joneshf commented Sep 4, 2018

Do you think it makes sense to push these optimization issues further upstream? Maybe into purescript-corefn if not all the way back up to purescript?

@felixSchl
Copy link
Collaborator Author

The optimizations in the PureScript codebase are performed on the JS AST, not on CoreFn, so I am not quite sure what you mean - would you mind elaborating?

@joneshf
Copy link

joneshf commented Sep 5, 2018

Some of these transformations could be performed on the CoreFn AST. Like, isn't the majority (if not all) of MagicDo converting calls to bind to let-bindings? Similarly, for things like function composition inlining, that could be done on the CoreFn AST.

There's some that won't work, like inlining (+) or whatever, but some of these could be pushed up to be done once and for all.

@felixSchl felixSchl removed the good first issue Good for newcomers label Sep 26, 2018
@felixSchl felixSchl added this to To do in Optimizations Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Optimizations
  
To do
Development

No branches or pull requests

2 participants