Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom-text-editor.Object.defineProperty.get is deprecated. #13

Open
Redabenmeradi opened this issue Jan 26, 2017 · 4 comments
Open

atom-text-editor.Object.defineProperty.get is deprecated. #13

Redabenmeradi opened this issue Jan 26, 2017 · 4 comments

Comments

@Redabenmeradi
Copy link

Redabenmeradi commented Jan 26, 2017

The contents of atom-text-editor elements are no longer encapsulated
within a shadow DOM boundary. Please, stop using shadowRoot and access
the editor contents directly instead.

atom-text-editor.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:68:18)
Object.toggle (/Users/reda.benmeradi/.atom/packages/chrome-color-picker/lib/chrome-color-picker.coffee:244:42)
atom-workspace.subscriptions.add.atom.commands.add.chrome-color-picker:toggle (/Users/reda.benmeradi/.atom/packages/chrome-color-picker/lib/chrome-color-picker.coffee:117:26)
CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:259:29)
handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:59)
CommandRegistry.dispatch (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:160:19)
@puranjayjain
Copy link
Owner

Will get down to it asap

@ghost
Copy link

ghost commented Jun 2, 2017

still getting the same error above hehe...

@puranjayjain
Copy link
Owner

@donvodki sorry couldn't get time to fix the issue. Will have to re work the entire component if I get some time

@carljdp
Copy link

carljdp commented Aug 17, 2017

Deprication Cop says: "The contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. Please, stop using shadowRoot and access the editor contents directly instead."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants