-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pulsar dep breaks refactor-nrepl plugin #43
Comments
I don't know much about
This is the project file (project generated with
Is that the issue you're running into? Else what's the trace/log, if any? How do you know the plugin is prevented from loading? If you can share a testable reproduction of the issue it can greatly help. |
This works with (defproject dep-test "0.1.0-SNAPSHOT"
:description "FIXME: write description"
:url "http://example.com/FIXME"
:license {:name "Eclipse Public License"
:url "http://www.eclipse.org/legal/epl-v10.html"}
:dependencies [[org.clojure/clojure "1.7.0"]]
:plugins [[refactor-nrepl "1.1.0"]]) This one breaks with the above error you quote. (defproject dep-test "0.1.0-SNAPSHOT"
:description "FIXME: write description"
:url "http://example.com/FIXME"
:license {:name "Eclipse Public License"
:url "http://www.eclipse.org/legal/epl-v10.html"}
:dependencies [[org.clojure/clojure "1.7.0"]
[co.paralleluniverse/pulsar "0.7.2"]]
:java-agents [[co.paralleluniverse/quasar-core "0.7.2"]]
:plugins [[refactor-nrepl "1.1.0"]]) And to be thorough 😉 this one works too: (defproject dep-test "0.1.0-SNAPSHOT"
:description "FIXME: write description"
:url "http://example.com/FIXME"
:license {:name "Eclipse Public License"
:url "http://www.eclipse.org/legal/epl-v10.html"}
:dependencies [[org.clojure/clojure "1.7.0"]
[co.paralleluniverse/pulsar "0.7.2"]]
:java-agents [[co.paralleluniverse/quasar-core "0.7.2"]]) |
Also interesting is that both of these work: (defproject dep-test "0.1.0-SNAPSHOT"
:description "FIXME: write description"
:url "http://example.com/FIXME"
:license {:name "Eclipse Public License"
:url "http://www.eclipse.org/legal/epl-v10.html"}
:dependencies [[org.clojure/clojure "1.7.0"]]
:java-agents [[co.paralleluniverse/quasar-core "0.7.2"]]
:plugins [[refactor-nrepl "1.1.0"]]) (defproject dep-test "0.1.0-SNAPSHOT"
:description "FIXME: write description"
:url "http://example.com/FIXME"
:license {:name "Eclipse Public License"
:url "http://www.eclipse.org/legal/epl-v10.html"}
:dependencies [[org.clojure/clojure "1.7.0"]
[co.paralleluniverse/pulsar "0.7.2"]]
:plugins [[refactor-nrepl "1.1.0"]]) |
Here (Linux Mint 17.2 Rafaela, Oracle JDK 1.8.0_60-b27 64-bit on MBP late 2008) this too breaks with the above error: (defproject dep-test "0.1.0-SNAPSHOT"
:description "FIXME: write description"
:url "http://example.com/FIXME"
:license {:name "Eclipse Public License"
:url "http://www.eclipse.org/legal/epl-v10.html"}
:dependencies [[org.clojure/clojure "1.7.0"]]
:plugins [[refactor-nrepl "1.1.0"]]) |
I'm running Ubuntu 15.04 -- Leiningen 2.5.2 on Java 1.8.0_60 Java HotSpot(TM) 64-Bit Server VM Also tried wiping out the my user profile. Turns out you need Here is the base then: (defproject dep-test "0.1.0-SNAPSHOT"
:description "FIXME: write description"
:url "http://example.com/FIXME"
:license {:name "Eclipse Public License"
:url "http://www.eclipse.org/legal/epl-v10.html"}
:dependencies [[org.clojure/clojure "1.7.0"]]
:plugins [[refactor-nrepl "1.1.0"]
[cider/cider-nrepl "0.9.1"]]) |
Adding This relates to classloading hierarchies anyway, for example Does this work for you? |
@circlespainter Adding I started with https://github.com/yogthos/pulsar-example and edited its (defproject pulsar-example "0.1.0-SNAPSHOT"
:description "a sample project using Pulsar"
:url "https://github.com/yogthos/pulsar-example"
:license {:name "Eclipse Public License"
:url "http://www.eclipse.org/legal/epl-v10.html"}
:dependencies [[org.clojure/clojure "1.7.0"]
[co.paralleluniverse/pulsar "0.7.3"]
[co.paralleluniverse/quasar-core "0.7.3"]]
:plugins [[refactor-nrepl "1.1.0"]
[cider/cider-nrepl "0.9.1"]]
:bootclasspath true
:manifest {"Premain-Class" "co.paralleluniverse.fibers.instrument.JavaAgent"
"Agent-Class" "co.paralleluniverse.fibers.instrument.JavaAgent"
"Can-Retransform-Classes" "true"
"Can-Redefine-Classes" "true"}
:java-agents [[co.paralleluniverse/quasar-core "0.7.3"]]
:main pulsar-example.core
:uberjar-name "pulsar-example.jar"
:aot [pulsar-example.core]) The REPL loaded just fine, but when I tried to run
|
A WorkaroundNormally, I have the To remove {:user {:plugins ^:replace [[lein-pprint "1.1.1"]
[cider/cider-nrepl "0.9.1"]]}} Notice that it doesn't include |
@beppu Thanks for posting a workaround. I'll be looking further into this issue. |
Same issue for me with pulsar 0.7.3. @beppu 's work-around works. (I too specify |
@circlespainter the problem you encountered in the second post of this thread is caused by your not specifying a |
Here are a few other threads discussing this same issue: |
@expez Thanks, it doesn't look like the instrumentation errors in clojure-emacs/refactor-nrepl#107 are the source of the issue because when not using auto-instrumentation I can see no errors in the full instrumentation logs (they can be obtained by adding Some tricky interaction with mranderson is possible but it sounds strange that it only happens with This definitely requires some more investigation. |
@circlespainter Thanks for your investigation! I would really love to have this solved, since |
does someone has a solution to this, im falling in the same error? also i wasnt able to remove refactor-nrepl as suggested because it is being called by emacs and i dont know how to prevent it from calling automatically, even though it isnt listed in my project.clj file. Any help is appreciated... |
@greboide to get rid of
|
nice, thank you @expez im such a noobie with clojure, i dont think im going to refactor just now, anyway it works like a charm without it! |
When I add pulsar as a dependency (with quasar), the refactor-nrepl plugin is prevented from loading. If I remove pulsar, the plugin starts working again. The cider-nrepl plugin does not have this issue. Not sure where this defect lies, if it is in the plugin or in plusar.
The text was updated successfully, but these errors were encountered: