Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ahead-of-Time Ant Task instrumentation for Comsat? #90

Open
vlad-poskatcheev-tealium opened this issue Dec 20, 2016 · 2 comments
Open
Assignees

Comments

@vlad-poskatcheev-tealium
Copy link

vlad-poskatcheev-tealium commented Dec 20, 2016

I'm running into an issue where it does not seem to be possible to instrument quasar-comsat classes ahead-of-time via a Maven Ant Task (as described in docs.paralleluniverse.co/quasar). Quasar Fibers log an instrumentation error and point to classes in quasar-comsat package.

General setup of my project:

  • using quasar-core
  • using quasar-comsat (in particular FiberHttpClientBuilder that wraps Apache Async Http client)
  • my project's code instantiates FiberHttpClientBuilder (note: all applicable methods are marked @Suspendable)

It works when using a Java Agent, but fails with AOT Ant Task because quasar-comsat classes are in a jar and not in the class build directory. Unfortunately my project is constrained and not able to use Java Agents.

Is there a way to make it work with AOT? One alternative (although a bit hacky) solution came to mind of including quasar-comsat classes directly within the code base (I only need a handful) and hence bypassing the quasar-comsat dependency all together?

@pron
Copy link
Contributor

pron commented Dec 22, 2016

Yes, that's a good point. Comsat classes should be instrumented AOT.

@pron pron self-assigned this Dec 22, 2016
@circlespainter
Copy link
Member

circlespainter commented May 9, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants