-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing suspendables in comsat-jdbi #84
Comments
I am using jdbi 2.73, but it is the same with 2.72, the version referenced in comsat-jdbi… |
Actually, I think there is a lot more missing… Some are related to all the SQL Object API way of using jdbi… it's a mess :) |
Here are some others:
|
A PR would be welcome. |
Once I am exactly clear on the problem, I would love to :) For example I don't exactly understand how all of this goes hand in hand with the See also my post on the mailing list which details the context of these issues: https://groups.google.com/forum/#!topic/comsat-user/j4oIEtxHW0I |
The classifier is a programmable way of marking suspendable methods. If we're dealing with generated methods (that don't always have the same class name), the classifier would be a good place to add them. |
@victornoel Could you also add corresponding test cases when you work on the PR? Thanks, expanding test (and use case) coverage is always a great thing. |
@circlespainter sorry, but I'm not sure I will be working on that for now (but if/when I do, I will add tests yes!), because it's too much hassle to make it works and the logs are filled with garbage (I'm not sure why, see the mailing list issue). |
Hi,
Apparently the following suspendables is missing in comsat-jdbi:
Or actually, I suspect that the following suspendables:
Should be:
As for
$1
, I don't know if it needs to be marked as suspendable, it is possible, but then it should be:The text was updated successfully, but these errors were encountered: