Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment Deployment Policy for tags #692

Closed
av-andrii-ievtukhov opened this issue Jun 13, 2024 · 2 comments
Closed

Environment Deployment Policy for tags #692

av-andrii-ievtukhov opened this issue Jun 13, 2024 · 2 comments
Assignees
@mjeffryes
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). blocked The issue cannot be resolved without 3rd party action. kind/enhancement Improvements or new features resolution/by-design This issue won't be fixed because the functionality is working as designed

Comments

@av-andrii-ievtukhov
Copy link

Hey guys!

We have a repository where we have to support deployments from both branches and tags, and we are not able to find information regarding tags in pulumi documentation here - https://www.pulumi.com/registry/packages/github/api-docs/repositoryenvironmentdeploymentpolicy/.

It seems it only supports the branchPattern option, not the tagPattern option.

What we want to achieve:

image

If there is a way to do it now, or maybe add this feature -> would be great)

Thanks!
@mjeffryes mjeffryes added the needs-triage Needs attention from the triage team label Jun 13, 2024
@mjeffryes
Copy link
Member

Hi @av-andrii-ievtukhov this is a great suggestion, but the reason we don't have the tagPattern on this resource today is that the upstream terraform provider only has branchPattern (see github_repository_environment_deployment_policy | Terraform Registry).

If you file an issue against https://github.com/integrations/terraform-provider-github and get the support added there, we'll pick it up in our provider soon after it's released there.

@mjeffryes mjeffryes added blocked The issue cannot be resolved without 3rd party action. awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). resolution/by-design This issue won't be fixed because the functionality is working as designed and removed needs-triage Needs attention from the triage team labels Jun 13, 2024
@mjeffryes mjeffryes self-assigned this Jun 13, 2024
@mjeffryes mjeffryes added the kind/enhancement Improvements or new features label Jun 13, 2024
@maksym-lutskyi
Copy link

Hi
They actually have already opened issue for that. But unfortunately PR for that is still in open state.
integrations/terraform-provider-github#2165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjeffryes mjeffryes

Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). blocked The issue cannot be resolved without 3rd party action. kind/enhancement Improvements or new features resolution/by-design This issue won't be fixed because the functionality is working as designed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjeffryes @maksym-lutskyi @av-andrii-ievtukhov