-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go builds are not supported for minimal config #14703
Comments
Correct flag usage is |
Minimal go builds are indeed broken.
|
Still looking into this. At this time, we do not have support for building minimal config with go tooling only. Bazel handles the type substitution at compile time where go is unable to do this. |
I'll also add that this is rather low priority for us. If someone is able to propose a PR then we would review and accept it quickly. The gist is that the protobuf templates have to be generated with the correct config, then protoc (with the appropriate plugins) has to regenerate the pb.go files. I don't immediately see a clean fix here for go builds with minimal config at compile time. Edit: ssz generated code would have to be regenerated too. |
Describe the bug
Related issue.
If I build prysm with bazel it works correctly for mainnet and minimal preset.
If I build prysm with go it works correctly only for mainnet preset.
If I try to run prysm using go build environment (
go build -tags="--config=minimal,blst_enabled,blst_portable"
) I get the following error:Another weird observation is that if I use a minimal preset image (using go built) with mainnet network settings the process starts up, but crashes with segfault after about 30 seconds.
segfault:
Has this worked before in a previous version?
🔬 Minimal Reproduction
kt config:
To repro the segfault
Error
Platform(s)
Mac (Apple Silicon)
What version of Prysm are you running? (Which release)
latest develop commit 30a136f
Anything else relevant (validator index / public key)?
N/A
cc: @mattevans
The text was updated successfully, but these errors were encountered: