Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate blob sidecar by range response #14674

Open
terencechain opened this issue Nov 26, 2024 · 0 comments
Open

Validate blob sidecar by range response #14674

terencechain opened this issue Nov 26, 2024 · 0 comments

Comments

@terencechain
Copy link
Member

terencechain commented Nov 26, 2024

Prysm nodes serving blobs by range requests do not verify that the blob sidecars stored in the database match the block commitment count. This could result in a Prysm node with insufficient blob sidecars in the database (it is unclear how this situation arises) servicing an incorrect number of blob sidecars matching the block's KZG commitment, thereby violating the following P2P specification rule:

Clients MUST include all blob sidecars of each block from which they include blob sidecars.

One naive solution is to check total indices matches the blob kzg commitments count before responding to peer:

idxs, err := s.cfg.blobStorage.Indices(b.Root())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant