You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was looking to work for #14166, and found there are several functions for converting different formats of p2p addresses(enode, ENR, multiaddr). For example, PeersFromStringAddrs for setting trusted peers from static peers works almost identically with parsePeersEnr in pubsub.go. Also MakePeer calls AddrInfoFromP2pAddr from go-libp2p/core/peer, just like other util functions do.
Description
I would like to deal with this redundancy to enhance dx and readbility for future work. I'd like to address #14166 also, by adding all types(enode, ENR, multiaddr) are acceptable. Could you assign for these tasks?
The text was updated successfully, but these errors were encountered:
💎 Issue
Background
I was looking to work for #14166, and found there are several functions for converting different formats of p2p addresses(enode, ENR, multiaddr). For example,
PeersFromStringAddrs
for setting trusted peers from static peers works almost identically withparsePeersEnr
inpubsub.go
. AlsoMakePeer
callsAddrInfoFromP2pAddr
fromgo-libp2p/core/peer
, just like other util functions do.Description
I would like to deal with this redundancy to enhance dx and readbility for future work. I'd like to address #14166 also, by adding all types(enode, ENR, multiaddr) are acceptable. Could you assign for these tasks?
The text was updated successfully, but these errors were encountered: