Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up p2p address util functions #14606

Open
syjn99 opened this issue Nov 2, 2024 · 1 comment
Open

Cleaning up p2p address util functions #14606

syjn99 opened this issue Nov 2, 2024 · 1 comment
Assignees

Comments

@syjn99
Copy link
Contributor

syjn99 commented Nov 2, 2024

💎 Issue

Background

I was looking to work for #14166, and found there are several functions for converting different formats of p2p addresses(enode, ENR, multiaddr). For example, PeersFromStringAddrs for setting trusted peers from static peers works almost identically with parsePeersEnr in pubsub.go. Also MakePeer calls AddrInfoFromP2pAddr from go-libp2p/core/peer, just like other util functions do.

Description

I would like to deal with this redundancy to enhance dx and readbility for future work. I'd like to address #14166 also, by adding all types(enode, ENR, multiaddr) are acceptable. Could you assign for these tasks?

@prestonvanloon
Copy link
Member

Thanks so much @syjn99. Could you please comment on #14166? I can't assign you unless you interact with that github issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants