Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3s reload of validator pubkeys #14551

Open
franjoespejo opened this issue Oct 17, 2024 · 3 comments
Open

w3s reload of validator pubkeys #14551

franjoespejo opened this issue Oct 17, 2024 · 3 comments
Labels
Enhancement New feature or request Web3Signer Web3Signer related tasks

Comments

@franjoespejo
Copy link

🚀 Feature Request

Description

Prysm implements the w3signer standard https://docs.prylabs.network/docs/wallet/web3signer, but it is unknown when the validator client requests the pubkeys to the w3s. For some w3s implementations, as diva (https://docs.divastaking.net/) the pubkeys array in the response is changing,

Describe the solution you'd like

We would need the validator client to periodically check the pubkeys the w3s is signing for in order to keep it up to date.

Nimbus or Lodestar vc are fetching the pubkeys from the w3s periodically for a given interval, that would be the ideal solution

@james-prysm james-prysm added the Web3Signer Web3Signer related tasks label Oct 17, 2024
@james-prysm
Copy link
Contributor

Nimbus or Lodestar vc are fetching the pubkeys from the w3s periodically for a given interval, that would be the ideal solution

is this ask for when a URL is provided? perhaps I didn't fully understand what you meant by checking pubkeys the w3s is signing for meant.

is this an alternative to using the keymanager APis to add and remove keys as needed?

@james-prysm james-prysm added the Enhancement New feature or request label Oct 17, 2024
@franjoespejo
Copy link
Author

Yes, that's for when a url is provided and would be an alternative to using keymanager APIs.

For more context,
The w3s url with the pubkeys of the validators that is ready to sign for:
https://ethereum.github.io/remote-signing-api/#/Public%20Key/PUBLIC_KEY_LIST

The issue is that most of the validator clients assume the w3s always signs for the same validators, and only retrieve that PUBLIC_KEY_LIST once.

@james-prysm
Copy link
Contributor

james-prysm commented Oct 17, 2024

I'm not sure if most people use it in that way to use the full list directly, I could be wrong, but I have heard of users using only a subset with multiple validators using the same w3s but different keys in the w3s. I'm not sure if this is a feature we should include yet.

perhaps there should be an API that triggers a refresh of the keys or something, not sure is adding the polling intervals is the best solution yet I could reach out to nimbus or lodestar maybe.

in any case will think more on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Web3Signer Web3Signer related tasks
Projects
None yet
Development

No branches or pull requests

3 participants
@franjoespejo @james-prysm and others