-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for native histograms #515
Comments
For protobuf, that is. To support pushing in the text format, first the text format has to support native histograms. Which will happen in OpenMetrics, not in the old text format, if at all. So then this depends on #400 . |
@jan--f is working on this. |
So far I think this will just work as is. So things to be done are:
The last item might benefit from aligning with improvements made in Prometheus itself? |
The Prometheus UI issue is prometheus/prometheus#11269 . Currently, the UI just displays the |
Displaying native histograms via Otherwise pushgateway just works with native histograms. Push via protobuf works as expected Scraping via protobuf works as expected Scraping with text format, give us an old-style histogram with a single bucket and a |
Thank you very much for all the work so far. The representation in the PGW UI is the "machine level" one, not the human-readable one that you can see in the Prometheus UI (also see my comment on #596). Another thought that crossed my mind: We do have an API that returns all the pushed metrics in JSON, see https://github.com/prometheus/pushgateway#url-2 . I wrongly assumed that the UI is using this API call, but it isn't (yet), it just uses Go HTML templating directly. However, that API endpoint also needs to support native histograms, because some users might use it for their own tooling. (And of course, a future UI might actually use the API endpoint as originally planned.) I assume some code is needed to create a makeshift JSON format. |
It's still an experimental feature, but it should be relatively easy to add support to the PGW.
The text was updated successfully, but these errors were encountered: