You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's an issue with my PR #871 as ttar is unable to extract the updated sys.ttar archive contents over the contents from older commits. (Developers will run into it but not TravisCI as it always starts with an empty builddir.)
I've reported the issue in ideaship/ttar#3 with a detailled test case and an suggested fix. It got merged into ttar but the recursive remove was changed into a (safer) rmdir which unfortunately is not good enough for the issue here in node-exporter as the directory is not empty.
Another solution would be to clear the collector/fixtures/sys/ directory before we extract the sys.ttar. Thoughts?
The text was updated successfully, but these errors were encountered:
As I mentioned in ideaship/ttar/issues/3, I am open to implementing the equivalent of GNU tar's "--recursive-unlink" option (which enables the desired, potentially dangerous behavior) in ttar. But that would still not clean out removed files.
There's an issue with my PR #871 as
ttar
is unable to extract the updatedsys.ttar
archive contents over the contents from older commits. (Developers will run into it but not TravisCI as it always starts with an empty builddir.)I've reported the issue in ideaship/ttar#3 with a detailled test case and an suggested fix. It got merged into
ttar
but the recursive remove was changed into a (safer)rmdir
which unfortunately is not good enough for the issue here innode-exporter
as the directory is not empty.Another solution would be to clear the
collector/fixtures/sys/
directory before we extract thesys.ttar
. Thoughts?The text was updated successfully, but these errors were encountered: