From cae7cda3c580813e088742882914e2b2288eeb55 Mon Sep 17 00:00:00 2001 From: Kemal Akkoyun Date: Thu, 17 Mar 2022 11:01:29 +0100 Subject: [PATCH 1/3] Add config to test against go1.18 Signed-off-by: Kemal Akkoyun --- .circleci/config.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4d355782..fc793212 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -94,12 +94,13 @@ workflows: - "1.15" - "1.16" - "1.17" + - "1.18" - test-assets: name: assets-go-<< matrix.go_version >> matrix: parameters: go_version: - - "1.17" + - "1.18" - style: name: style - go_version: "1.17" + go_version: "1.18" From bab8e1a174d8d27b797e626b583b6d4102f891be Mon Sep 17 00:00:00 2001 From: Kemal Akkoyun Date: Thu, 17 Mar 2022 14:28:50 +0100 Subject: [PATCH 2/3] Upgrade go orb Change convinient image base Signed-off-by: Kemal Akkoyun --- .circleci/config.yml | 98 ++++++++++++++++++++++---------------------- 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index fc793212..28b8664f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,7 +2,7 @@ version: 2.1 orbs: - go: circleci/go@0.2.0 + go: circleci/go@1.7.1 jobs: test: @@ -13,23 +13,23 @@ jobs: type: boolean default: true docker: - - image: circleci/golang:<< parameters.go_version >> + - image: cimg/go:<< parameters.go_version >> steps: - - checkout - - when: - condition: << parameters.use_gomod_cache >> - steps: - - go/load-cache: - key: v1-go<< parameters.go_version >> - - run: make test - - run: make -C sigv4 test - - when: - condition: << parameters.use_gomod_cache >> - steps: - - go/save-cache: - key: v1-go<< parameters.go_version >> - - store_test_results: - path: test-results + - checkout + - when: + condition: << parameters.use_gomod_cache >> + steps: + - go/load-cache: + key: v1-go<< parameters.go_version >> + - run: make test + - run: make -C sigv4 test + - when: + condition: << parameters.use_gomod_cache >> + steps: + - go/save-cache: + key: v1-go<< parameters.go_version >> + - store_test_results: + path: test-results test-assets: parameters: go_version: @@ -38,22 +38,22 @@ jobs: type: boolean default: true docker: - - image: circleci/golang:<< parameters.go_version >> + - image: cimg/go:<< parameters.go_version >> steps: - - checkout - - when: - condition: << parameters.use_gomod_cache >> - steps: - - go/load-cache: - key: v1-go<< parameters.go_version >> - - run: make -C assets test - - when: - condition: << parameters.use_gomod_cache >> - steps: - - go/save-cache: - key: v1-go<< parameters.go_version >> - - store_test_results: - path: test-results + - checkout + - when: + condition: << parameters.use_gomod_cache >> + steps: + - go/load-cache: + key: v1-go<< parameters.go_version >> + - run: make -C assets test + - when: + condition: << parameters.use_gomod_cache >> + steps: + - go/save-cache: + key: v1-go<< parameters.go_version >> + - store_test_results: + path: test-results style: parameters: go_version: @@ -62,24 +62,24 @@ jobs: type: boolean default: true docker: - - image: circleci/golang:<< parameters.go_version >> + - image: cimg/go:<< parameters.go_version >> steps: - - checkout - - when: - condition: << parameters.use_gomod_cache >> - steps: - - go/load-cache: - key: v1-go<< parameters.go_version >> - - run: make style - - run: make -C sigv4 style - - run: make -C assets style - - when: - condition: << parameters.use_gomod_cache >> - steps: - - go/save-cache: - key: v1-go<< parameters.go_version >> - - store_test_results: - path: test-results + - checkout + - when: + condition: << parameters.use_gomod_cache >> + steps: + - go/load-cache: + key: v1-go<< parameters.go_version >> + - run: make style + - run: make -C sigv4 style + - run: make -C assets style + - when: + condition: << parameters.use_gomod_cache >> + steps: + - go/save-cache: + key: v1-go<< parameters.go_version >> + - store_test_results: + path: test-results workflows: version: 2 From be549b79435b0c513b677531293b37d2715dcea9 Mon Sep 17 00:00:00 2001 From: Kemal Akkoyun Date: Fri, 18 Mar 2022 08:00:17 +0100 Subject: [PATCH 3/3] Reconcile github ui Signed-off-by: Kemal Akkoyun