Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency for floats (mini.files, mini.clue, and mini.pick incl. trouble.nvim, etc.) #337

Closed
231tr0n opened this issue Jul 1, 2024 · 1 comment · Fixed by #351
Closed

Comments

@231tr0n
Copy link

231tr0n commented Jul 1, 2024

When transparency is turned on, mini.files, mini.clue and mini.pick still have background including trouble.nvim.
image
image
image
image

@231tr0n 231tr0n changed the title Transparency for mini.files, mini.clue and mini.pick. Transparency for mini.files, mini.clue and mini.pick including trouble.nvim. Jul 6, 2024
@tmillr
Copy link
Member

tmillr commented Jul 13, 2024

Gotta figure out how options.transparent = true should combine with options.darken.floats = true. It should probably just override it (as is currently done for sidebars in this case) and just use transparency instead (plus, it's not like we can trivially figure out, implicitly, what the terminal bg is in order to make the float bg darker than it). Ideally, the floats config would be changed to an enum of string (e.g. 'transparent' | 'darken') instead of a boolean, but then it'd probably have to be moved out of options.darken. Either that or a notice in the docs that options.transparent overrules options.darken.* when both are enabled.

Also have to make sure that neovim handles this properly/intelligently and doesn't act similar to vim.wo.winblend = 100 when a float has its bg unset (EDIT: can confirm that it doesn't do this). Because then text from vim windows underneath the float would leak through and be visible.

tmillr added a commit that referenced this issue Jul 16, 2024
@tmillr tmillr changed the title Transparency for mini.files, mini.clue and mini.pick including trouble.nvim. Transparency for floats (mini.files, mini.clue, and mini.pick incl. trouble.nvim, etc.) Jul 16, 2024
@tmillr tmillr closed this as completed in 8e0afee Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants