Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_dark_high_contrast colorscheme is not using options.styles config #307

Open
aLucaz opened this issue Nov 17, 2023 · 5 comments
Open

Comments

@aLucaz
Copy link

aLucaz commented Nov 17, 2023

normal dark:

image

high contrast:

image

my config:

          styles = {                   -- Style to be applied to different syntax groups
            comments = 'italic',     -- Value is any valid attr-list value `:help attr-list`
            functions = 'NONE',
            keywords = 'italic',
            variables = 'NONE',
            conditionals = 'NONE',
            constants = 'NONE',
            numbers = 'NONE',
            operators = 'NONE',
            strings = 'NONE',
            types = 'NONE',
          },

also some keywords are not being considered like: function, import, from

@gennadigennadigennadi
Copy link

Same problem with the github_light theme.

@av223119
Copy link

I observe the issue with github_dark_dimmed, but surprisingly NOT with github_light or github_dark_high_contrast.

@rubensrbr
Copy link

Same problem with "github_dark_default"

@mabugaj
Copy link

mabugaj commented Jan 15, 2024

Ok for everyone that are having the same issue. I've spent some quality time to get my comments italic. For Lazy here is how the code looks like (options keyword is crucial here):

{
  "projekt0n/github-nvim-theme",
  lazy = false,
  priority = 1000,
  config = function()
    require("github-theme").setup({
      options = {
        styles = {
          comments = "italic",
        },
      },
    })
  end,
}

After that open new nvim instance and invoke in the cmd mode :GithubThemeCompile and after that it should work properly. Hope this helps someone.

Also this should be put, with exclamation mark, into the the README file, cause like we see a lot people are having problem with it.

ful1e5 added a commit that referenced this issue Jan 19, 2024
@tmillr
Copy link
Member

tmillr commented Jul 12, 2024

The compiler issue is mostly fixed at this point. Is anyone still experiencing this issue (after updating)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants