sidebar is not darkened when configured to do so (affects neo-tree, etc.) #306
Labels
bug
Something isn't working
Comments
|
Facing the same issue. Currently, I need to manually change the highlight group |
|
I have the same issue with NvimTree as well |
tmillr
added a commit
to tmillr/github-nvim-theme
that referenced
this issue
Jul 10, 2024
Problem: `options.darken.sidebars.enabled` and
`options.darken.sidebars.enable` both exist, but it is only one
option. The default in `config.lua` is `enable`, but it is
referred to as `enabled` as well (both in code and docs). It
used to be `enable` but was renamed to `enabled`, so it is
technically supposed to be `options.darken.sidebars.enabled` at
this time (as of this commit's parent).
Solution: Revert `options.darken.sidebars.enabled` back to
`options.darken.sidebars.enable`. This brings it back in-line
with the changelog and runtime deprecation checks. `enable` is
also more consistent as this is what is used in other parts
of the config (e.g. config for `modules`). Continue to accept
`options.darken.sidebars.enabled` for backwards-compatibility.
Either may be used: `enabled` is now coerced to `enable` in
`config.lua`.
Problem: In a couple of places, `options.darken.sidebars` is checked for
truthiness. This seems to be a typo of
`options.darken.sidebars.enable` which is a boolean (unlike the
former, which is a table by default and also documented as a
table). Tables are always truthy.
Solution: Use `options.darken.sidebars.enable` instead of
`options.darken.sidebars` in conditionals.
Reverts: fff3e20, 806903c
Fixes: projekt0n#306
branch upstream-main
ur branch is ahead of 'upstream/main' by 1 commit.
(use "git push" to publish your local commits)
tmillr
added a commit
to tmillr/github-nvim-theme
that referenced
this issue
Jul 10, 2024
Problem: `options.darken.sidebars.enabled` and
`options.darken.sidebars.enable` both exist, but it is only one
option. The default in `config.lua` is `enable`, but it is
referred to as `enabled` as well (both in code and docs). It
used to be `enable` but was renamed to `enabled`, so it is
technically supposed to be `options.darken.sidebars.enabled` at
this time (as of this commit's parent).
Solution: Revert `options.darken.sidebars.enabled` back to
`options.darken.sidebars.enable`. This brings it back in-line
with the changelog and runtime deprecation checks. `enable` is
also more consistent as this is what is used in other parts
of the config (e.g. config for `modules`). Continue to accept
`options.darken.sidebars.enabled` for backwards-compatibility.
Either may be used: `enabled` is now coerced to `enable` in
`config.lua`.
Problem: In a couple of places, `options.darken.sidebars` is checked for
truthiness. This seems to be a typo of
`options.darken.sidebars.enable` which is a boolean (unlike the
former, which is a table by default and also documented as a
table). Tables are always truthy.
Solution: Use `options.darken.sidebars.enable` instead of
`options.darken.sidebars` in conditionals.
Reverts: fff3e20, 806903c
Fixes: projekt0n#306
tmillr
added a commit
to tmillr/github-nvim-theme
that referenced
this issue
Jul 12, 2024
Problem: `options.darken.sidebars.enabled` and
`options.darken.sidebars.enable` both exist, but it is only one
option. The default in `config.lua` is `enable`, but it is
referred to as `enabled` as well (both in code and docs). It
used to be `enable` but was renamed to `enabled`, so it is
technically supposed to be `options.darken.sidebars.enabled` at
this time (as of this commit's parent).
Solution: Revert `options.darken.sidebars.enabled` back to
`options.darken.sidebars.enable`. This brings it back in-line
with the changelog and runtime deprecation checks. `enable` is
also more consistent as this is what is used in other parts
of the config (e.g. config for `modules`). Continue to accept
`options.darken.sidebars.enabled` for backwards-compatibility.
Either may be used: `enabled` is now coerced to `enable` in
`config.lua`.
Problem: In a couple of places, `options.darken.sidebars` is checked for
truthiness. This seems to be a typo of
`options.darken.sidebars.enable` which is a boolean (unlike the
former, which is a table by default and also documented as a
table). Tables are always truthy.
Solution: Use `options.darken.sidebars.enable` instead of
`options.darken.sidebars` in conditionals.
Reverts: fff3e20, 806903c
Fixes: projekt0n#306
tmillr
changed the title
tmillr
changed the title
tmillr
added a commit
to tmillr/github-nvim-theme
that referenced
this issue
Jul 12, 2024
Problem: `options.darken.sidebars.enabled` and
`options.darken.sidebars.enable` both exist, but it is only one
option. The default in `config.lua` is `enable`, but it is
referred to as `enabled` as well (both in code and docs). It
used to be `enable` but was renamed to `enabled`, so it is
technically supposed to be `options.darken.sidebars.enabled` at
this time (as of this commit's parent).
Solution: Deprecate and revert `options.darken.sidebars.enabled` back to
`options.darken.sidebars.enable`. This brings it back in-line
with the changelog and runtime deprecation checks. `enable` is
also more consistent as this is what is used in other parts
of the config (e.g. config for `modules`).
Problem: In a couple of places, `options.darken.sidebars` is checked for
truthiness. This seems to be a typo of
`options.darken.sidebars.enable` which is a boolean (unlike the
former, which is a table by default and also documented as a
table). Tables are always truthy.
Solution: Use `options.darken.sidebars.enable` instead of
`options.darken.sidebars` in conditionals.
Reverts: fff3e20, 806903c
Fixes: projekt0n#306
tmillr
added a commit
to tmillr/github-nvim-theme
that referenced
this issue
Jul 12, 2024
Problem: `options.darken.sidebars.enabled` and
`options.darken.sidebars.enable` both exist, but it is only one
option. The default in `config.lua` is `enable`, but it is
referred to as `enabled` as well (both in code and docs). It
used to be `enable` but was renamed to `enabled`, so it is
technically supposed to be `options.darken.sidebars.enabled` at
this time (as of this commit's parent).
Solution: Deprecate and revert `options.darken.sidebars.enabled` back to
`options.darken.sidebars.enable`. This brings it back in-line
with the changelog and runtime deprecation checks. `enable` is
also more consistent as this is what is used in other parts
of the config (e.g. config for `modules`).
Problem: In a couple of places, `options.darken.sidebars` is checked for
truthiness. This seems to be a typo of
`options.darken.sidebars.enable` which is a boolean (unlike the
former, which is a table by default and also documented as a
table). Tables are always truthy.
Solution: Use `options.darken.sidebars.enable` instead of
`options.darken.sidebars` in conditionals.
Reverts: fff3e20, 806903c
Fixes: projekt0n#306
tmillr
added a commit
to tmillr/github-nvim-theme
that referenced
this issue
Jul 12, 2024
Problem: `options.darken.sidebars.enabled` and
`options.darken.sidebars.enable` both exist, but it is only one
option. The default in `config.lua` is `enable`, but it is
referred to as `enabled` as well (both in code and docs). It
used to be `enable` but was renamed to `enabled`, so it is
technically supposed to be `options.darken.sidebars.enabled` at
this time (as of this commit's parent).
Solution: Deprecate and revert `options.darken.sidebars.enabled` back to
`options.darken.sidebars.enable`. This brings it back in-line
with the changelog and runtime deprecation checks. `enable` is
also more consistent as this is what is used in other parts
of the config (e.g. config for `modules`).
Problem: In a couple of places, `options.darken.sidebars` is checked for
truthiness. This seems to be a typo of
`options.darken.sidebars.enable` which is a boolean (unlike the
former, which is a table by default and also documented as a
table). Tables are always truthy.
Solution: Use `options.darken.sidebars.enable` instead of
`options.darken.sidebars` in conditionals.
Reverts: fff3e20, 806903c
Fixes: projekt0n#306
tmillr
added a commit
to tmillr/github-nvim-theme
that referenced
this issue
Jul 12, 2024
Problem: `options.darken.sidebars.enabled` and
`options.darken.sidebars.enable` both exist, but it is only one
option. The default in `config.lua` is `enable`, but it is
referred to as `enabled` as well (both in code and docs). It
used to be `enable` but was renamed to `enabled`, so it is
technically supposed to be `options.darken.sidebars.enabled` at
this time (as of this commit's parent).
Solution: Deprecate and revert `options.darken.sidebars.enabled` back to
`options.darken.sidebars.enable`. This brings it back in-line
with the changelog and runtime deprecation checks. `enable` is
also more consistent as this is what is used in other parts
of the config (e.g. config for `modules`).
Problem: In a couple of places, `options.darken.sidebars` is checked for
truthiness. This seems to be a typo of
`options.darken.sidebars.enable` which is a boolean (unlike the
former, which is a table by default and also documented as a
table). Tables are always truthy.
Solution: Use `options.darken.sidebars.enable` instead of
`options.darken.sidebars` in conditionals.
Reverts: fff3e20, 806903c
Fixes: projekt0n#306
tmillr
added a commit
to tmillr/github-nvim-theme
that referenced
this issue
Jul 18, 2024
Problem: `options.darken.sidebars.enabled` and
`options.darken.sidebars.enable` both exist, but it is only one
option. The default in `config.lua` is `enable`, but it is
referred to as `enabled` as well (both in code and docs). It
used to be `enable` but was renamed to `enabled`, so it is
technically supposed to be `options.darken.sidebars.enabled` at
this time (as of this commit's parent).
Solution: Deprecate and revert `options.darken.sidebars.enabled` back to
`options.darken.sidebars.enable`. This brings it back in-line
with the changelog and runtime deprecation checks. `enable` is
also more consistent as this is what is used in other parts
of the config (e.g. config for `modules`).
Problem: In a couple of places, `options.darken.sidebars` is checked for
truthiness. This seems to be a typo of
`options.darken.sidebars.enable` which is a boolean (unlike the
former, which is a table by default and also documented as a
table). Tables are always truthy.
Solution: Use `options.darken.sidebars.enable` instead of
`options.darken.sidebars` in conditionals.
Reverts: fff3e20
Reverts: 806903c
Fixes: projekt0n#306
tmillr
added a commit
that referenced
this issue
Jul 18, 2024
Problem: `options.darken.sidebars.enabled` and
`options.darken.sidebars.enable` both exist, but it is only one
option. The default in `config.lua` is `enable`, but it is
referred to as `enabled` as well (both in code and docs). It
used to be `enable` but was renamed to `enabled`, so it is
technically supposed to be `options.darken.sidebars.enabled` at
this time (as of this commit's parent).
Solution: Deprecate and revert `options.darken.sidebars.enabled` back to
`options.darken.sidebars.enable`. This brings it back in-line
with the changelog and runtime deprecation checks. `enable` is
also more consistent as this is what is used in other parts
of the config (e.g. config for `modules`).
Problem: In a couple of places, `options.darken.sidebars` is checked for
truthiness. This seems to be a typo of
`options.darken.sidebars.enable` which is a boolean (unlike the
former, which is a table by default and also documented as a
table). Tables are always truthy.
Solution: Use `options.darken.sidebars.enable` instead of
`options.darken.sidebars` in conditionals.
Reverts: fff3e20
Reverts: 806903c
Fixes: #306
|
Sorry for the delay. This should be fixed now. Please leave a comment here or open a new issue if you are still experiencing problems after updating your plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using neovim 0.9.4, I can't seem to get the 'darkened sidebar' to work.
I've even tried explicitly setting the sidebars list with:
{ "projekt0n/github-nvim-theme", priority = 1000, lazy = false, config = function() require("github-theme").setup({ options = { darken = { sidebars = { enable = true, list = { "neo-tree" }, }, }, }, }) end, },but no dice.
The text was updated successfully, but these errors were encountered: