Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is that what you meant #15

Open
LazzaAU opened this issue Oct 16, 2020 · 4 comments
Open

Is that what you meant #15

LazzaAU opened this issue Oct 16, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@LazzaAU
Copy link
Contributor

LazzaAU commented Oct 16, 2020

The feature " is that what you want " needs fine tuning.

test Case

first request i purposely requested wrong - " turn on the long light"
second request (and correct request) -- "turn on the awning light"

Alice responds " is this what you meant when you said turn on the long light ?
I replied "yes"
and she went into training

All good that's what i expected and wanted. However .....

In dialogTemplate of "AliceCore" she added "turn on the long light" to the slot type of "Alice/AnswerYesNo" , which in my mind is wrong. ??

she should be

  • finding the skill that has the correct intent ( in this case HA skill)
  • then adding "long light" as a synonym for the slot value that the correct intent is using ( in this case HA skill slot "swichNames" value "awning light")
@Psychokiller1888 Psychokiller1888 self-assigned this Oct 16, 2020
@Psychokiller1888 Psychokiller1888 added the bug Something isn't working label Oct 16, 2020
@Psychokiller1888
Copy link
Member

Yep, never saw that, weird. Of course it should add the utterance to the correct intent

@LazzaAU
Copy link
Contributor Author

LazzaAU commented Oct 30, 2020

In somewhere like slotsAsObjects, would it be possible to add a result which is something like

"callingSkill" : "Path" ,

where "Path" would be the path to the skill of the "recognised intent"

I was just looking into ways to correct the above "is that what you meant" , and to be able to add the correct synonym or utterance to the correct dialogTemplate file we would first need to find out which skill had the correct Intent and i can't see in the current session where that would be possible. I don't feel self.getResource() is not a feesible option in this senario

Just a thought

@Psychokiller1888
Copy link
Member

I just pushed a possible fix: project-alice-assistant/ProjectAlice@39e37b6

@LazzaAU
Copy link
Contributor Author

LazzaAU commented Oct 30, 2020

transferring comment from that commit to here:

:smiles: Ok so maybe i was overthinking that part of it a little. Works good. Puts the utterance under the right intent.

however i'd suspect at some stage phase two would be to work out how to add slots to that intent or put it as a synonym ? as the utterance on its own will only trigger the intent not the actions/slots inside the intent ? or am i still over thinking it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants