Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grammar mistakes in answers #18

Open
maxbachmann opened this issue Aug 9, 2019 · 3 comments
Open

grammar mistakes in answers #18

maxbachmann opened this issue Aug 9, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@maxbachmann
Copy link
Contributor

maxbachmann commented Aug 9, 2019

in the skill Alice Satellite there is for example the training example
```what is the temperature {outside:=>Room}``
the answer is:
"It is currently {1} degrees in the {0}",
This has two problems:

  1. when the room is for example outside, the answer sentence should be
    it is currently 5 degrees outside and not is is currently 5 degrees in the outside
  2. when the temperature is a singular (1 degree or -1 degree) the answer should include degree instead of degrees

The same issue probably appears in other places aswell. So there should be another option to the current random.talk function to set language specific behavior and pluralise functions to get the grammar stuff right.

Might make sence to use:
https://docs.python.org/3/library/gettext.html,
since it is highly different between languages when the singular and when the plural is used

@maxbachmann maxbachmann self-assigned this Sep 27, 2019
@Psychokiller1888 Psychokiller1888 added the enhancement New feature or request label Oct 5, 2019
@Psychokiller1888
Copy link
Member

Be carefull with alice satellite. Many things, like the temperature, are gone. Telemetry module is due to overtake it all

@maxbachmann
Copy link
Contributor Author

ok

@maxbachmann
Copy link
Contributor Author

This can be handled using project-alice-assistant/ProjectAlice#133 in the future

@maxbachmann maxbachmann removed their assignment Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants