Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0480: Mechanism is upgraded on every log in but never offered #4328

Open
mdosch opened this issue Dec 17, 2024 · 1 comment
Open

XEP-0480: Mechanism is upgraded on every log in but never offered #4328

mdosch opened this issue Dec 17, 2024 · 1 comment

Comments

@mdosch
Copy link

mdosch commented Dec 17, 2024

Environment

  • ejabberd version: 24.10.48-messaging.one
  • Erlang version: unknown
  • OS: unix/linux 6.1.0
  • Installed from: unknown

Bug description

While the upgrade according to XEP-0480 works (upgrade from SCRAM-SHA-1 to SCRAM-SHA-512 via UPGR-SCRAM-SHA-512) SCRAM-SHA-512 is not offered during the next log in and the update is performed again.

So currently it just makes the authentication more expensive as it adds the overhead of upgrading to every log in but never offers the new mechanism. AFAIU ejabberd should offer SCRAM-SHA-512 to accounts which already performed the upgrade while keeping SCRAM-SHA-1 hashes stored as well for use with older clients. Probably it would make sense to store when a certain mechanism was last used and delete the corresponding hashes when not used in a configurable time frame.

CC: @tmolitor-stud-tu @weiss

@licaon-kter
Copy link
Contributor

Duplicate of #4301 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants