Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Enable the diagram navigation in the "overlays" demo #63

Closed
tbouffard opened this issue Aug 21, 2023 · 0 comments · Fixed by #135
Closed

[FEAT] Enable the diagram navigation in the "overlays" demo #63

tbouffard opened this issue Aug 21, 2023 · 0 comments · Fixed by #135
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tbouffard
Copy link
Member

tbouffard commented Aug 21, 2023

Is your feature request related to a problem? Please describe.
The BPMN navigation doesn't remove the style applied externally from mxGraph (to hide the overlays) by a call to OverlaysPlugin.setVisible (see #62).

It is currently not activated in the demo because when doing a panning to the bottom of the page, the container height increases.
See the following video 👇🏿.

demo_OverlaysPlugin_support_navigation.mp4

Describe the solution you'd like
Enable the navigation in this demo and update the design to make the panning correctly work.
As for all demo where the BPMN navigation is enabled, also add a "Fit" button to reset the rendering at its initial state.

Describe alternatives you've considered
N/A

Additional context
The panning behavior probably occurs because the height is not detected as a 'fixed' value.
The CSS rules are the same as for the "PathResolver" demo and it recently changed to not used "fixed" height. See #61.
We use flex-grow in the demo of the bpmn-visualization and we don't have such an issue. We should have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant