Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does smee convert from application/x-www-form-urlencoded to application/json automatically? #293

Open
tanin47 opened this issue Mar 3, 2024 · 2 comments
Labels

Comments

@tanin47
Copy link

tanin47 commented Mar 3, 2024

I tested a webhook using webhook.site, and it shows that the body is form-urlencoded. When I use smee client locally, the body that I get in my local server is a JSON (though the header is still application/x-www-form-urlencoded). I wonder if there's a way to disable to automatic conversion.

@DrJume
Copy link

DrJume commented Mar 13, 2024

We're also having the same issue! This causes different behaviour between local and prod. This is not acceptable, it should forward the body as is.

@AaronDewes AaronDewes added the bug label Mar 13, 2024
@wolfy1339
Copy link
Contributor

Probot and Octokit have never supported application/x-www-form-urlencoded

I merged #297, does that fix your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants