Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the VSCode peripheral viewer with mcu-debug #65

Open
kossnikita opened this issue Oct 24, 2023 · 6 comments
Open

Replace the VSCode peripheral viewer with mcu-debug #65

kossnikita opened this issue Oct 24, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@kossnikita
Copy link

kossnikita commented Oct 24, 2023

Currently, the built-in peripheral viewer has less functionality compared to mcu-debug/peripheral-viewer.

From what I noticed:

  • Enumerations are ignored
  • Ignored register size (always 32 bits)
  • Writing does not work in my case

Does it make sense to use peripheral-viewer instead? I think the idea behind this extension is very similar to the viewer in your extension. It has been used with cortex-debug for quite some time, so it will be a little familiar to developers switching to Rust from C.

If replacement is not possible, is it at least possible to transfer the functionality of this extension to your extension?

Extensions comparison
image
image

@kossnikita kossnikita added the enhancement New feature or request label Oct 24, 2023
@Yatekii
Copy link
Member

Yatekii commented Oct 25, 2023

This is something that I was working on but never finished. I wrote a web based viewer that is more featureful than either of the two :) I wanna continue that at some point.

@burrbull
Copy link

Should be moved to https://github.com/probe-rs/vscode

@Yatekii Yatekii transferred this issue from probe-rs/probe-rs Oct 26, 2023
@kossnikita
Copy link
Author

I wasn't sure that this relative to this repository, because I didn't find device peripheral logic in it

@kossnikita
Copy link
Author

I wrote a web based viewer

Is this already published somewhere?

@Yatekii
Copy link
Member

Yatekii commented Oct 26, 2023

It's a branch in the probe-rs/cargo-embed repository :)

@noppej
Copy link
Contributor

noppej commented Oct 26, 2023

There is no reason why such functionality cannot be delivered as part of the VSCode extension. The VSCode API, and DAP Protocol extensibility, would make it relatively smooth to present it in a integrated view as part of the debug extension.

I wrote the current integration as a "proof of concept", to judge usage and requirement, and because I use it myself. The total lack of feedback to this point has lowered the priority in terms of my own efforts.

That said, if you @kossnikita (or anybody else) were interested in PR'ing, I'd be happy to review and support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants