Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Precompile: 0x09 blake2f #326

Open
ChihChengLiang opened this issue Nov 23, 2022 · 5 comments
Open

Precompile: 0x09 blake2f #326

ChihChengLiang opened this issue Nov 23, 2022 · 5 comments

Comments

@ChihChengLiang
Copy link
Collaborator

No description provided.

@Brechtpd
Copy link
Collaborator

Brechtpd commented Dec 9, 2022

We can take this one (should be fairly similar to sha256) if nobody else is working on it already.

@CPerezz
Copy link
Member

CPerezz commented Dec 9, 2022

I'm happy that you take it @Brechtpd ! But please, let's try to re-use the CellManager of keccak-multi or the one of the EVM instead of creating an extra one. As the plan is to merge all them in future PRs

@KimiWu123 KimiWu123 moved this from 🆕 Product Backlog Items to Milestone Tasks in zkEVM Community Edition Oct 25, 2023
@KimiWu123 KimiWu123 added this to the Feature Completeness milestone Oct 25, 2023
@ed255
Copy link
Member

ed255 commented Nov 30, 2023

@Brechtpd did you work on this / are you working on this? Not to put any pressure! It's just to figure out if this task should be unassigned :)

@CPerezz
Copy link
Member

CPerezz commented Nov 30, 2023

I think MatterLabs has an implementation of this that is pretty optimized.
We could take a look and see if we can reuse some stuff from there giving credit OFC.

@Brechtpd
Copy link
Collaborator

We have a blake2f circuit here: taikoxyz/zkevm-circuits#56. But it will likely require some changes and some extra work to make it usable in a precompile. It's unlikely we're going to spend more time on this on our end, so unassigning makes sense I think.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: 🆕 Product Backlog Items
Development

No branches or pull requests

5 participants