Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define export type IMTNode = number | string | bigint; directly istead of any. #339

Open
0xDatapunk opened this issue Oct 7, 2024 · 0 comments
Open

define export type IMTNode = number | string | bigint; directly istead of any. #339

0xDatapunk opened this issue Oct 7, 2024 · 0 comments
Labels
audit 🔍 This issue is related to an audit. good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature

Comments

@0xDatapunk
Copy link
Collaborator

zk-kit/packages/imt/src/types/index.ts

Line 4 in c912111

export type IMTNode = any

for JS/imt, it is clearer to define export type IMTNode = number | string | bigint; directly istead of any.
All functions require such types anyway
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ZK-Kit Oct 7, 2024
@cedoor cedoor added audit 🔍 This issue is related to an audit. refactoring ♻️ A code change that neither fixes a bug nor adds a feature labels Oct 14, 2024
@cedoor cedoor mentioned this issue Oct 16, 2024
Closed
@cedoor cedoor added the good first issue Good for newcomers label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit 🔍 This issue is related to an audit. good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
ZK-Kit
Status: ♻️ Grooming
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cedoor @0xDatapunk