Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: comparison before updating #322

Open
0xDatapunk opened this issue Sep 11, 2024 · 1 comment
Open

update: comparison before updating #322

0xDatapunk opened this issue Sep 11, 2024 · 1 comment
Labels
audit 🔍 This issue is related to an audit. good first issue Good for newcomers question ❔ Further information is requested refactoring ♻️ A code change that neither fixes a bug nor adds a feature

Comments

@0xDatapunk
Copy link
Collaborator

0xDatapunk commented Sep 11, 2024 •
edited
Loading

zk-kit/packages/imt/src/imt.ts

Line 227 in aa02c6d

let node = newLeaf

does it make sense to check if newLeaf != this._nodes[0][index] first?
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ZK-Kit Sep 11, 2024
@cedoor cedoor added audit 🔍 This issue is related to an audit. refactoring ♻️ A code change that neither fixes a bug nor adds a feature labels Sep 12, 2024
@cedoor cedoor added the question ❔ Further information is requested label Oct 16, 2024
@cedoor
Copy link
Member

cedoor commented Oct 24, 2024

Yes, it makes sense!

@cedoor cedoor added the good first issue Good for newcomers label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit 🔍 This issue is related to an audit. good first issue Good for newcomers question ❔ Further information is requested refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
ZK-Kit
Status: ♻️ Grooming
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cedoor @0xDatapunk