Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ETag and Last-Modified to the handler.ts #13

Open
dohomi opened this issue Sep 20, 2017 · 2 comments · May be fixed by #52
Open

add ETag and Last-Modified to the handler.ts #13

dohomi opened this issue Sep 20, 2017 · 2 comments · May be fixed by #52

Comments

@dohomi
Copy link

dohomi commented Sep 20, 2017 •
edited
Loading

In the handler.ts you are adding following headers:

headers: {
      'Content-Type': ContentType,
      'Content-Disposition': ContentDisposition,
      'Cache-Control': 'max-age=31536000',
    },

It would be great if you could add ETag and Last-Modified as well to improve the caching options and increase a better SEO rating.
Thanks!
@dohomi dohomi changed the title add ETag and ExpiredHeaders to the handler.ts add ETag and Last-Modified to the handler.ts Sep 20, 2017
@schickling
Copy link
Contributor

Would you mind creating a PR for this?

@dohomi
Copy link
Author

dohomi commented Feb 8, 2018

@schickling sorry I haven't had much time lately but now this issue gets more important for me. Is there any good guidance how to start? I want to deploy a website based on graphcool and I get downgraded on Google Pagespeed and YSlow due to this issue

@dohomi dohomi linked a pull request Mar 5, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ETag to header output dohomi/serverless-image-proxy
2 participants
@dohomi @schickling