Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWEEnv refactoring tasks #535

Open
8 tasks
klieret opened this issue Jun 4, 2024 · 0 comments
Open
8 tasks

SWEEnv refactoring tasks #535

klieret opened this issue Jun 4, 2024 · 0 comments
Assignees

Comments

@klieret
Copy link
Member

klieret commented Jun 4, 2024

  • sha from swe-agent is never used
  • Remove aliases to self.args (e.g., self.image_name=args.image_name) if they aren't modified later
  • clean_multi_line_functions not used?
  • self.idx not used?
  • self.communicate_output never read?
  • self.base_commit is only an alias?
  • Make self.reset simply return container, container_obj, record, so that they're never None and mypy shuts up
  • Clean up all the confusion between all the different reset, _reset, _init, close, etc.
@klieret klieret self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant