Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] CTA banner themed variant #607

Open
nsolerieu opened this issue Jun 12, 2024 · 0 comments
Open

[Feature Request] CTA banner themed variant #607

nsolerieu opened this issue Jun 12, 2024 · 0 comments

Comments

@nsolerieu
Copy link
Contributor

Goal

Add a new theme prop to the CTA banner component with a set of background shapes as a additional control

See Loom walkthrough here
Figma file for full specs

Specs

Background shapes
Image

Applied to brand pillar themes
Image

Using CSS pseudo element allow for a code only approach

  • Plugs on top of existing component
  • Flexes on mobile
  • No performance issues
  • Potential color update needed for a11y
  • Extends the latest bento visual language

Extra parameters

  • Disable left aligned for this expressive variant only (to avoid breaking change)
  • Color theme agnostic variant would render the in light/dark modes
  • Octicon should be optional toggle on/off
  • Nice to have: animated reveal + onhover states
animated-ctabanner.mov
@raytalks raytalks added the brand label Jun 14, 2024
@raytalks raytalks added this to Overview in Primer Brand roadmap Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants