Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect v18: Wrong placeholder color - missing p-placeholder class #16479

Closed
TaneliTuomola opened this issue Oct 3, 2024 · 1 comment
Closed

MultiSelect v18: Wrong placeholder color - missing p-placeholder class #16479

TaneliTuomola opened this issue Oct 3, 2024 · 1 comment
Assignees
@mehmetcetin01140
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
18.0.0-rc.2

Comments

@TaneliTuomola
Copy link

Describe the bug

Placeholder color is wrong. The element does not get the correct formatting because the correct class(p-placeholder) is not set for it.
image
Image: PrimeVue vs PrimeNg

Environment

https://v18.primeng.org/multiselect#basic

Reproducer

https://v18.primeng.org/multiselect#basic

Angular version

18.0.5

PrimeNG version

18.0.0-beta.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.6.0

Browser(s)

No response

Steps to reproduce the behavior

https://v18.primeng.org/multiselect#basic

Expected behavior

https://primevue.org/multiselect/#basic
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 3, 2024
@TaneliTuomola
Copy link
Author

Still present in version 18.0.0-beta.3

The p-placeholder class must be set to the p-multiselect-label element when the placeholder text is displayed.
@cetincakiroglu

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan added this to the 18.0.0-rc.2 milestone Nov 19, 2024
@mertsincan mertsincan removed this from PrimeNG Nov 20, 2024
@cetincakiroglu cetincakiroglu self-assigned this Nov 21, 2024
@mertsincan mertsincan modified the milestones: 18.0.0-rc.2, 18.0.0.Final Nov 26, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 29, 2024
mehmetcetin01140 added a commit that referenced this issue Nov 29, 2024
@mehmetcetin01140
Fixed #16479 | MultiSelect v18: Wrong placeholder color - missing p-p…
4ac372c 
…laceholder class
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Nov 29, 2024
Merged
mehmetcetin01140 added a commit that referenced this issue Nov 29, 2024
@mehmetcetin01140
Merge pull request #16885 from primefaces/issue-16479
2c87193 
Fixed #16479 | MultiSelect v18: Wrong placeholder color - missing p-p…
@mehmetcetin01140 mehmetcetin01140 moved this to Done in PrimeNG Nov 29, 2024
@mehmetcetin01140 mehmetcetin01140 closed this as completed by moving to Done in PrimeNG Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
18.0.0-rc.2
Development

No branches or pull requests
5 participants
@cagataycivici @mertsincan @cetincakiroglu @TaneliTuomola @mehmetcetin01140