-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flag to Set Start/End Dates to Earliest/Latest Day of Year #7
Comments
That is actually something that I was missing just now! |
@cgo Would you want something like |
@prikhi thanks for coming back! I was thinking more along the lines of --period (and then a time period), and one option that fetches prices newer than the latest recorded price that is already in the target journal file. |
Yes something like We actually don't have to worry about fetching too many prices - AlphaVantage always returns all the history they have in one single API call, our code then filters the response for the dates we care about. That said, either of those flags will take a bit more time to implement compared to |
It's nice for users when addons can provide flags somewhat consistent with hledger's. periodFromRawOpts could be a useful helper here, but it's not exported. We should change that. |
Yes something like that, and more like what @simonmichael was saying in his reply I guess. Interesting that Alphavantage is just sending all they have, I didn't know that. Seems a bit wasteful on their side. |
Currently, the start/end dates are based on the entry dates in the journal file. Start is the earliest entry's date, end is the last entry's date.
Add a new flag to set the start/end dates to the first day of the earliest year and the last day of the latest year, respectively.
The text was updated successfully, but these errors were encountered: